Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Autoconfigure SsmClient even if config import is not used #1233

Merged
merged 3 commits into from
Sep 25, 2024
Merged

Autoconfigure SsmClient even if config import is not used #1233

merged 3 commits into from
Sep 25, 2024

Conversation

Forfend
Copy link
Contributor

@Forfend Forfend commented Sep 25, 2024

📢 Type of change

  • Bugfix
  • New feature
  • Enhancement
  • Refactoring

📜 Description

Implements #1231

💡 Motivation and Context

This PR solves the issue described in #1231 It creates autoconfiguration for the SsmClient

💚 How did you test it?

📝 Checklist

  • I reviewed submitted code
  • I added tests to verify changes
  • I updated reference documentation to reflect the change
  • All tests passing
  • No breaking changes

🔮 Next steps

@github-actions github-actions bot added the component: parameter-store Parameter Store integration related issue label Sep 25, 2024
@maciejwalkowiak maciejwalkowiak added this to the 3.3.0 milestone Sep 25, 2024
@maciejwalkowiak
Copy link
Contributor

Thanks @Forfend for quick PR! To not repeat the same mistake as with Secrets Manager (#1232), I added little change.

@maciejwalkowiak maciejwalkowiak merged commit 14d82c2 into awspring:main Sep 25, 2024
4 checks passed
@Forfend Forfend deleted the gh-1231 branch September 25, 2024 14:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@maciejwalkowiak maciejwalkowiak maciejwalkowiak approved these changes

@MatejNedic MatejNedic Awaiting requested review from MatejNedic MatejNedic is a code owner

@tomazfernandes tomazfernandes Awaiting requested review from tomazfernandes tomazfernandes is a code owner

Assignees
No one assigned
Labels
component: parameter-store Parameter Store integration related issue
Projects
None yet
Milestone
3.3.0
Development

Successfully merging this pull request may close these issues.
2 participants
@Forfend @maciejwalkowiak